zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hanm <...@git.apache.org>
Subject [GitHub] zookeeper pull request #241: ZOOKEEPER-2662: Export a metric for txn log syn...
Date Thu, 27 Apr 2017 18:59:42 GMT
Github user hanm commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/241#discussion_r113776378
  
    --- Diff: src/java/test/org/apache/zookeeper/server/persistence/FileTxnSnapLogTest.java
---
    @@ -113,6 +116,26 @@ public void testAutoCreateDb() throws IOException {
             attemptAutoCreateDb(dataDir, snapDir, sessions, priorAutocreateDbValue, "false",
0L);
         }
     
    +    @Test
    +    public void testGetTxnLogSyncElapsedTime() throws IOException {
    --- End diff --
    
    This tests the sync time, but not the bean. It is a good test case to have, but it would
be also good to add server bean test for the methods added in this patch (see ZooKeeperServerBeanTest).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message