zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From afine <...@git.apache.org>
Subject [GitHub] zookeeper pull request #227: ZOOKEEPER-2755 Allow to subclass ClientCnxnSock...
Date Thu, 27 Apr 2017 00:08:50 GMT
Github user afine commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/227#discussion_r113590962
  
    --- Diff: src/java/test/org/apache/zookeeper/test/NettyLocalSuiteTest.java ---
    @@ -0,0 +1,35 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.zookeeper.test;
    +
    +import org.junit.runners.Suite;
    +
    +/**
    + * Run tests with: Netty Client against Netty server
    + */
    +@Suite.SuiteClasses({
    --- End diff --
    
    > But IMHO a new system property/run time flag will add the need to run always twice
the full suite at every build/release.
    
    Maybe. We have a good degree of flakyness in our testing and wondering if using this type
of change for our precommit  hook will increase performance and stability (especially if we
can use something similar for server<->server).
    
    > At this moment I think it is not the time to add an official "local transport" netty
connection factory.
    
    Agreed.
    
    > I can't find how to enable Netty for server-to-server communications
    
    It is currently not possible. All communications there are handled by old fashioned sockets.
 I was incorrect in my other comment, although I still think my point is valid. Is there a
way to have similar functionality with old fashioned java sockets? I don't think this change
makes too much sense for testing unless we can take zk off the OS network stack entirely.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message