zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From afine <...@git.apache.org>
Subject [GitHub] zookeeper pull request #223: ZOOKEEPER-2316: comment does not match code log...
Date Mon, 24 Apr 2017 22:04:43 GMT
Github user afine commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/223#discussion_r113068086
  
    --- Diff: src/java/main/org/apache/zookeeper/server/quorum/Leader.java ---
    @@ -724,6 +724,8 @@ synchronized public boolean tryToCommit(Proposal p, long zxid, SocketAddress
fol
            // concurrent reconfigs are allowed, this can happen.
            if (outstandingProposals.containsKey(zxid - 1)) return false;
            
    +       // in order to be committed, a proposal must be accepted by a quorum
    +       //
    --- End diff --
    
    @hanm I think the blank line may be fine, it provides separation from the idea on the
next line so it doesn't read as a single sentence. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message