zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hanm <...@git.apache.org>
Subject [GitHub] zookeeper pull request #232: ZOOKEEPER-2731: Cleanup findbug warnings in bra...
Date Mon, 24 Apr 2017 17:48:59 GMT
Github user hanm commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/232#discussion_r113011930
  
    --- Diff: src/java/main/org/apache/jute/compiler/JType.java ---
    @@ -27,7 +27,7 @@
     	private String mCName;
         private String mCppName;
         private String mCsharpName;
    -    private String mJavaName;
    +    protected String mJavaName;
    --- End diff --
    
    Haven't looked into detail here, but one observation is that our trunk and branch 3.5
is find bug free, and it does not require this private - protected change here.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message