zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hanm <...@git.apache.org>
Subject [GitHub] zookeeper pull request #222: ZOOKEEPER-2697 Handle graceful stop of ZookKeep...
Date Mon, 24 Apr 2017 17:35:35 GMT
Github user hanm commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/222#discussion_r113008830
  
    --- Diff: src/java/main/org/apache/zookeeper/ZooKeeper.java ---
    @@ -1325,6 +1325,23 @@ public synchronized void close() throws InterruptedException {
         }
     
         /**
    +     * Close this client object as the {@link #close() } method.
    +     * This method will wait for internal resources to be released.
    +     *
    +     * @param waitForShutdownTimeoutMs timeout (in milliseconds) to wait for resources
to be released.
    +     * Use zero or a negative value to skip the wait
    +     * @throws InterruptedException
    +     * @return true if waitForShutdownTimeout is greater than zero and all of the resources
have been released
    +     */
    +    public boolean close(int waitForShutdownTimeoutMs) throws InterruptedException {
    +        close();
    +        if (waitForShutdownTimeoutMs > 0) {
    --- End diff --
    
    I don't think this check is needed - actually, it sounds better to remove this check so
a negative value will trigger illegal argument exception indicates something is wrong in upstream
code, because it's hard to know if the negative value is passed on purpose, or is an accident.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message