zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From afine <...@git.apache.org>
Subject [GitHub] zookeeper pull request #184: ZOOKEEPER-236: SSL Support for Atomic Broadcast...
Date Fri, 14 Apr 2017 17:11:13 GMT
Github user afine commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/184#discussion_r111603427
  
    --- Diff: src/java/main/org/apache/zookeeper/common/X509Util.java ---
    @@ -150,7 +196,7 @@ public static X509KeyManager createKeyManager(String keyStoreLocation,
String ke
                 KeyStore ks = KeyStore.getInstance("JKS");
                 inputStream = new FileInputStream(keyStoreFile);
                 ks.load(inputStream, keyStorePasswordChars);
    -            KeyManagerFactory kmf = KeyManagerFactory.getInstance("SunX509");
    +            KeyManagerFactory kmf = KeyManagerFactory.getInstance("PKIX");
    --- End diff --
    
    A comment has been added where pkix is used for the trustmanager factory. We don't actually
need this change for the keymanager, but i preferred to be consistent.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message