zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hanm <...@git.apache.org>
Subject [GitHub] zookeeper pull request #184: ZOOKEEPER-236: SSL Support for Atomic Broadcast...
Date Thu, 13 Apr 2017 21:03:02 GMT
Github user hanm commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/184#discussion_r111486591
  
    --- Diff: src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java ---
    @@ -383,6 +387,7 @@ public void run() {
                             + leader.self.getView().get(this.sid).toString());
                 } else {
                     LOG.info("Follower sid: " + this.sid + " not in the current config "
+ Long.toHexString(leader.self.getQuorumVerifier().getVersion()));
    +                //TODO: Hostname verification possible
    --- End diff --
    
    Suggest to remove this TODO as it appertains to no code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message