zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shralex <...@git.apache.org>
Subject [GitHub] zookeeper pull request #215: Four-letter words to voluntarily shed client co...
Date Mon, 10 Apr 2017 17:21:43 GMT
Github user shralex commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/215#discussion_r110712848
  
    --- Diff: src/java/test/org/apache/zookeeper/test/ShedClientsTest.java ---
    @@ -0,0 +1,161 @@
    +/**
    --- End diff --
    
    This test uses a single server and client, which doesn't seem ideal to test probabilities.
    Consider doing something similar to src/java/test/org/apache/zookeeper/test/StaticHostProviderTest.java
    which was developed as part of ZK-1355 for testing zk.updatedServerList()


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message