zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hanm <...@git.apache.org>
Subject [GitHub] zookeeper pull request #184: ZOOKEEPER-236: SSL Support for Atomic Broadcast...
Date Thu, 06 Apr 2017 01:09:18 GMT
Github user hanm commented on a diff in the pull request:

    --- Diff: src/java/main/org/apache/zookeeper/server/quorum/Learner.java ---
    @@ -230,15 +232,15 @@ protected void sockConnect(Socket sock, InetSocketAddress addr,
int timeout)
          * Establish a connection with the Leader found by findLeader. Retries
          * until either initLimit time has elapsed or 5 tries have happened. 
    -     * @param addr - the address of the Leader to connect to.
    +     * @param leader - the QuorumServer elected leader
          * @throws IOException - if the socket connection fails on the 5th attempt
          * @throws ConnectException
          * @throws InterruptedException
    -    protected void connectToLeader(InetSocketAddress addr) 
    -    throws IOException, ConnectException, InterruptedException {
    -        sock = new Socket();        
    -        sock.setSoTimeout(self.tickTime * self.initLimit);
    +    protected void connectToLeader(QuorumServer leader)
    +    throws IOException, InterruptedException, X509Exception {
    +        QuorumX509Util quorumX509Util = new QuorumX509Util();
    --- End diff --
    We now create QuorumX509Util whenever connectToLeader is called, even if ssl is not enabled.
Could this be improved so the SSL related code path is only involved when ssl is enabled?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message