Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@zookeeper.apache.org
Date: Fri, 24 Mar 2017 02:43:43 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: dev@zookeeper.apache.org
Message-ID: <JIRA.13058698.1490293850000.108521.1490323423566@Atlassian.JIRA>
In-Reply-To: <JIRA.13058698.1490293850000@Atlassian.JIRA>
References: <JIRA.13058698.1490293850000@Atlassian.JIRA> <JIRA.13058698.1490293850170@jira-lw-us.apache.org>
Subject: [jira] [Commented] (ZOOKEEPER-2736) Add a connection rate limiter
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Fri, 24 Mar 2017 02:43:56 -0000


    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15939613#comment-15939613 ] 

ASF GitHub Bot commented on ZOOKEEPER-2736:
-------------------------------------------

Github user eribeiro commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/205#discussion_r107820652
  
    --- Diff: src/java/main/org/apache/zookeeper/common/RateLimiter.java ---
    @@ -0,0 +1,99 @@
    +/**
    +* Licensed to the Apache Software Foundation (ASF) under one
    +* or more contributor license agreements.  See the NOTICE file
    +* distributed with this work for additional information
    +* regarding copyright ownership.  The ASF licenses this file
    +* to you under the Apache License, Version 2.0 (the
    +* "License"); you may not use this file except in compliance
    +* with the License.  You may obtain a copy of the License at
    +*
    +*     http://www.apache.org/licenses/LICENSE-2.0
    +*
    +* Unless required by applicable law or agreed to in writing, software
    +* distributed under the License is distributed on an "AS IS" BASIS,
    +* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +* See the License for the specific language governing permissions and
    +* limitations under the License.
    +*/
    +
    +package org.apache.zookeeper.common;
    +
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +/**
    + * A connection rate limiter.
    + *
    + */
    +public interface RateLimiter {
    +
    +    /**
    +     * If maxClientCnxnRate or maxClientCnxnBurst is set to this value, rate is
    +     * not limited
    +     */
    +    public static int BYPASS = -1;
    +
    +    /**
    +     * A {@code RateLimiter} that does not do any rate limiting
    +     */
    +    public static RateLimiter BYPASS_RATE_LIMITER = new RateLimiter() {
    --- End diff --
    
    As above, no need for public static modifiers.


> Add a connection rate limiter
> -----------------------------
>
>                 Key: ZOOKEEPER-2736
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2736
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: server
>    Affects Versions: 3.4.9, 3.5.2
>            Reporter: Vincent Poon
>         Attachments: ZOOKEEPER-2736.v1.patch
>
>
> Currently the maxClientCnxns property only limits the aggregate number of connections from a client, but not the rate at which connections can be created.
> This patch adds a configurable connection rate limiter which limits the rate as well.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)