Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@zookeeper.apache.org
Date: Mon, 27 Mar 2017 17:54:42 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: dev@zookeeper.apache.org
Message-ID: <JIRA.12895299.1442884404000.134166.1490637282854@Atlassian.JIRA>
In-Reply-To: <JIRA.12895299.1442884404000@Atlassian.JIRA>
References: <JIRA.12895299.1442884404000@Atlassian.JIRA> <JIRA.12895299.1442884404051@jira-lw-us.apache.org>
Subject: [jira] [Commented] (ZOOKEEPER-2280) NettyServerCnxnFactory doesn't
 honor maxClientCnxns param
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 27 Mar 2017 17:55:01 -0000


    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15943732#comment-15943732 ] 

ASF GitHub Bot commented on ZOOKEEPER-2280:
-------------------------------------------

Github user afine commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/208#discussion_r108230180
  
    --- Diff: src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java ---
    @@ -524,17 +538,14 @@ public InetSocketAddress getLocalAddress() {
     
         private void addCnxn(NettyServerCnxn cnxn) {
             cnxns.add(cnxn);
    -        synchronized (ipMap){
    -            InetAddress addr =
    -                ((InetSocketAddress)cnxn.channel.getRemoteAddress())
    -                    .getAddress();
    -            Set<NettyServerCnxn> s = ipMap.get(addr);
    -            if (s == null) {
    -                s = new HashSet<NettyServerCnxn>();
    -            }
    -            s.add(cnxn);
    -            ipMap.put(addr,s);
    +
    +        InetAddress addr = ((InetSocketAddress)cnxn.channel.getRemoteAddress()).getAddress();
    --- End diff --
    
    I think it may be cleaner to inline this method instead of casting again.


> NettyServerCnxnFactory doesn't honor maxClientCnxns param
> ---------------------------------------------------------
>
>                 Key: ZOOKEEPER-2280
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2280
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 3.4.6, 3.5.0, 3.5.1
>            Reporter: Edward Ribeiro
>            Assignee: Edward Ribeiro
>             Fix For: 3.5.4, 3.6.0
>
>         Attachments: ZOOKEEPER-2280.2.patch, ZOOKEEPER-2280.patch
>
>
> Even though NettyServerCnxnFactory has maxClientCnxns (default to 60) it doesn't enforce this limit in the code.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)