Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id C736E200C28 for ; Mon, 13 Mar 2017 17:22:52 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id C5D8A160B60; Mon, 13 Mar 2017 16:22:52 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 164B5160B85 for ; Mon, 13 Mar 2017 17:22:51 +0100 (CET) Received: (qmail 12699 invoked by uid 500); 13 Mar 2017 16:22:14 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 9318 invoked by uid 99); 13 Mar 2017 16:22:12 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Mar 2017 16:22:12 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 5ACD218231E for ; Mon, 13 Mar 2017 16:22:12 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.451 X-Spam-Level: * X-Spam-Status: No, score=1.451 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_NEUTRAL=0.652] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id i9Asme3xPCqa for ; Mon, 13 Mar 2017 16:22:11 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 3C54460D7F for ; Mon, 13 Mar 2017 16:22:07 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D441AE0D3B for ; Mon, 13 Mar 2017 16:22:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id AAC5C24430 for ; Mon, 13 Mar 2017 16:22:00 +0000 (UTC) Date: Mon, 13 Mar 2017 16:22:00 +0000 (UTC) From: "Michael Han (JIRA)" To: dev@zookeeper.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (ZOOKEEPER-1520) A txn log record with a corrupt sentinel byte looks like EOF MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 13 Mar 2017 16:22:53 -0000 [ https://issues.apache.org/jira/browse/ZOOKEEPER-1520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Han updated ZOOKEEPER-1520: ----------------------------------- Fix Version/s: (was: 3.5.3) 3.5.4 > A txn log record with a corrupt sentinel byte looks like EOF > ------------------------------------------------------------ > > Key: ZOOKEEPER-1520 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1520 > Project: ZooKeeper > Issue Type: Bug > Components: server > Affects Versions: 3.3.5 > Environment: all > Reporter: Bill Bridge > Assignee: Bill Bridge > Priority: Minor > Labels: newbie, patch > Fix For: 3.5.4, 3.6.0 > > Attachments: ant.out, checkout.out, init.out, init.out, ZOOKEEPER-1520.patch > > Original Estimate: 24h > Remaining Estimate: 24h > > In Util.readTxnBytes() the sentinel is compared with 0x42 and if it does not match then the record is considered partially written and thus the EOF. However if it is a partial record the sentinel should be 0x00 since that is what the log is initialized with. Any other value would indicate corruption and should throw an IOException rather than indicate EOF. See [ZOOKEEPER-1453|https://issues.apache.org/jira/browse/ZOOKEEPER-1453] for a related issue. -- This message was sent by Atlassian JIRA (v6.3.15#6346)