Return-Path: <dev-return-58083-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 1E8FE200C5D
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Fri, 24 Mar 2017 03:43:27 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
	id 1D3F5160B92; Fri, 24 Mar 2017 02:43:27 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 8D85E160B84
	for <archive-asf-public@cust-asf.ponee.io>; Fri, 24 Mar 2017 03:43:26 +0100 (CET)
Received: (qmail 24813 invoked by uid 500); 24 Mar 2017 02:43:20 -0000
Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@zookeeper.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@zookeeper.apache.org>
List-Post: <mailto:dev@zookeeper.apache.org>
List-Id: <dev.zookeeper.apache.org>
Reply-To: dev@zookeeper.apache.org
Delivered-To: mailing list dev@zookeeper.apache.org
Received: (qmail 23760 invoked by uid 99); 24 Mar 2017 02:43:19 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 24 Mar 2017 02:43:19 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 3C228E2F41; Fri, 24 Mar 2017 02:43:19 +0000 (UTC)
From: eribeiro <git@git.apache.org>
To: dev@zookeeper.apache.org
Reply-To: dev@zookeeper.apache.org
References: <git-pr-205-zookeeper@git.apache.org>
In-Reply-To: <git-pr-205-zookeeper@git.apache.org>
Subject: [GitHub] zookeeper pull request #205: ZOOKEEPER-2736 Add a connection rate limiter
Content-Type: text/plain
Message-Id: <20170324024319.3C228E2F41@git1-us-west.apache.org>
Date: Fri, 24 Mar 2017 02:43:19 +0000 (UTC)
archived-at: Fri, 24 Mar 2017 02:43:27 -0000

Github user eribeiro commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/205#discussion_r107825629
  
    --- Diff: src/java/main/org/apache/zookeeper/server/NIOServerCnxnFactory.java ---
    @@ -607,9 +618,28 @@ public static ByteBuffer getDirectBuffer() {
         // sessionMap is used by closeSession()
         private final ConcurrentHashMap<Long, NIOServerCnxn> sessionMap =
             new ConcurrentHashMap<Long, NIOServerCnxn>();
    -    // ipMap is used to limit connections per IP
    -    private final ConcurrentHashMap<InetAddress, Set<NIOServerCnxn>> ipMap =
    -        new ConcurrentHashMap<InetAddress, Set<NIOServerCnxn>>( );
    +    // ipMap is used to limit connections and connection rate per IP
    +    private final ConcurrentHashMap<InetAddress, IpCnxns> ipMap
    --- End diff --
    
    If you are changing we can declare the field as `ConcurrentMap`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---