Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@zookeeper.apache.org
From: shralex <git@git.apache.org>
To: dev@zookeeper.apache.org
Reply-To: dev@zookeeper.apache.org
References: <git-pr-190-zookeeper@git.apache.org>
In-Reply-To: <git-pr-190-zookeeper@git.apache.org>
Subject: [GitHub] zookeeper pull request #190: ZOOKEEPER-2718: fix flaky StandaloneDisabledTes...
Content-Type: text/plain
Message-Id: <20170314050041.0F4D1DFE20@git1-us-west.apache.org>
Date: Tue, 14 Mar 2017 05:00:41 +0000 (UTC)
archived-at: Tue, 14 Mar 2017 05:00:43 -0000

Github user shralex commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/190#discussion_r105828217
  
    --- Diff: src/java/test/org/apache/zookeeper/server/quorum/StandaloneDisabledTest.java ---
    @@ -102,6 +102,8 @@ public void startSingleServerTest() throws Exception {
                 Assert.fail("Should have been BadArgumentsException!");
             }
     
    +        // Kill server 1 to avoid it interferences with FLE of the quorum {2, 3, 4}.
    +        shutDownServer(1);
    --- End diff --
    
    replace 1 with follower1 and perhaps move up, to line 92


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---