From dev-return-57256-apmail-zookeeper-dev-archive=zookeeper.apache.org@zookeeper.apache.org Mon Mar 13 16:22:29 2017 Return-Path: X-Original-To: apmail-zookeeper-dev-archive@www.apache.org Delivered-To: apmail-zookeeper-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 41F1119386 for ; Mon, 13 Mar 2017 16:22:29 +0000 (UTC) Received: (qmail 5485 invoked by uid 500); 13 Mar 2017 16:22:09 -0000 Delivered-To: apmail-zookeeper-dev-archive@zookeeper.apache.org Received: (qmail 5430 invoked by uid 500); 13 Mar 2017 16:22:09 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 5321 invoked by uid 99); 13 Mar 2017 16:22:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Mar 2017 16:22:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 71D901A0898 for ; Mon, 13 Mar 2017 16:22:08 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.651 X-Spam-Level: X-Spam-Status: No, score=0.651 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_NEUTRAL=0.652] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id CCO2lqlAfkqe for ; Mon, 13 Mar 2017 16:22:07 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id CE1FA60D8B for ; Mon, 13 Mar 2017 16:22:04 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id EFD1FE0BCA for ; Mon, 13 Mar 2017 16:21:59 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id E6536243E8 for ; Mon, 13 Mar 2017 16:21:58 +0000 (UTC) Date: Mon, 13 Mar 2017 16:21:58 +0000 (UTC) From: "Michael Han (JIRA)" To: dev@zookeeper.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (ZOOKEEPER-991) QuoromPeer.OBSERVER_ID MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ZOOKEEPER-991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Han updated ZOOKEEPER-991: ---------------------------------- Fix Version/s: (was: 3.5.3) 3.5.4 > QuoromPeer.OBSERVER_ID > ---------------------- > > Key: ZOOKEEPER-991 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-991 > Project: ZooKeeper > Issue Type: Bug > Components: quorum > Affects Versions: 3.3.2 > Environment: Windows > Reporter: Sandeep Maheshwari > Fix For: 3.5.4, 3.6.0 > > > I don't understand why do we even need this code at first place. > if (remoteSid == QuorumPeer.OBSERVER_ID) { > /* > * Choose identifier at random. We need a value to identify > * the connection. > */ > remoteSid = observerCounter--; > initializeMessageQueue(remoteSid); > LOG.info("Setting arbitrary identifier to observer: " + remoteSid); > } > Even if remove above code from public Long readRemoteServerID(Socket sock) {} function the FLE will work correctly. Because when any other peer(PARTICIPANT) receive a notification from the observer, that peer won't consider his(observer) vote because of this check > if(!self.getVotingView().containsKey(response.sid)) > Hence there is no need of that code. Also bcoz to above code there is a possibility of creating redundant threads (SendWorker-ReceiveWorker) bcoz when same participant try to initiate connection with same peer we are doing (sid = observerCounter--;). So the same observer getting different sid and hence corresponding thread would be crated which will be of no use. > Please let me know if i am correct. -- This message was sent by Atlassian JIRA (v6.3.15#6346)