zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2738) maxClientCnxns not limiting concurrent connections properly
Date Tue, 28 Mar 2017 01:51:41 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15944383#comment-15944383
] 

Hadoop QA commented on ZOOKEEPER-2738:
--------------------------------------

+1 overall.  GitHub Pull Request  Build
      

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/486//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/486//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/486//console

This message is automatically generated.

> maxClientCnxns not limiting concurrent connections properly
> -----------------------------------------------------------
>
>                 Key: ZOOKEEPER-2738
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2738
>             Project: ZooKeeper
>          Issue Type: Bug
>    Affects Versions: 3.5.2, 3.6.0
>            Reporter: Vincent Poon
>         Attachments: MaxCnxnsTest.patch
>
>
> The test MaxCnxnsTest is incorrect as it only creates up the maxCnxns number of threads,
whereas it should create more.  See attached patch
> When the test is fixed, it fails on master and 3.5, where ZOOKEEPER-1504 removed some
synchronization.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message