zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2738) maxClientCnxns not limiting concurrent connections properly
Date Mon, 27 Mar 2017 17:26:41 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15943684#comment-15943684
] 

ASF GitHub Bot commented on ZOOKEEPER-2738:
-------------------------------------------

GitHub user vincentpoon opened a pull request:

    https://github.com/apache/zookeeper/pull/209

    ZOOKEEPER-2738 maxClientCnxns not limiting concurrent connections pro…

    …perly
    
    The problem was that in branch-3.5+ , because of ZOOKEEPER-1504, we now have one acceptor
thread and multiple selector threads.  The acceptor thread was checking the max connections,
but adding the connection to the ipMap (used to check maxCnxnCount) was done in the selector
threads.  As a result, when many connections come in concurrently, the acceptor thread can
potentially accept many connections before the selector threads have a chance to update the
ipMap.
    
    This patch updates the ipMap from the acceptor thread immediately.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vincentpoon/zookeeper ZOOKEEPER-2738

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zookeeper/pull/209.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #209
    
----
commit c4fdafbf94f8e6296a349eb10ff02f2d77a2ddb8
Author: Vincent <vincent.poon@salesforce.com>
Date:   2017-03-27T17:19:37Z

    ZOOKEEPER-2738 maxClientCnxns not limiting concurrent connections properly

----


> maxClientCnxns not limiting concurrent connections properly
> -----------------------------------------------------------
>
>                 Key: ZOOKEEPER-2738
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2738
>             Project: ZooKeeper
>          Issue Type: Bug
>    Affects Versions: 3.5.2, 3.6.0
>            Reporter: Vincent Poon
>         Attachments: MaxCnxnsTest.patch
>
>
> The test MaxCnxnsTest is incorrect as it only creates up the maxCnxns number of threads,
whereas it should create more.  See attached patch
> When the test is fixed, it fails on master and 3.5, where ZOOKEEPER-1504 removed some
synchronization.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message