zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2725) Upgrading to a global session fails with a multiop
Date Sun, 19 Mar 2017 03:42:41 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15931548#comment-15931548
] 

ASF GitHub Bot commented on ZOOKEEPER-2725:
-------------------------------------------

Github user hanm commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/195#discussion_r106797340
  
    --- Diff: src/java/test/org/apache/zookeeper/server/MultiOpSessionUpgradeTest.java ---
    @@ -0,0 +1,87 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.zookeeper.server;
    +
    +import org.apache.zookeeper.CreateMode;
    +import org.apache.zookeeper.KeeperException;
    +import org.apache.zookeeper.Op;
    +import org.apache.zookeeper.OpResult;
    +import org.apache.zookeeper.ZooDefs;
    +import org.apache.zookeeper.ZooKeeper;
    +import org.apache.zookeeper.test.ClientBase;
    +import org.apache.zookeeper.test.QuorumBase;
    +import org.junit.Assert;
    +import org.junit.Test;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +import java.io.IOException;
    +import java.util.Arrays;
    +import java.util.List;
    +
    +public class MultiOpSessionUpgradeTest extends QuorumBase {
    +    protected static final Logger LOG = LoggerFactory.getLogger(MultiOpSessionUpgradeTest.class);
    +
    +    @Override
    +    public void setUp() throws Exception {
    +        localSessionsEnabled = true;
    +        localSessionsUpgradingEnabled = true;
    +        super.setUp();
    +    }
    +
    +    @Test
    +    public void ephemeralCreateMultiOpTest() throws KeeperException, InterruptedException,
IOException {
    +        final ZooKeeper zk = createClient();
    +        waitForClient(zk, ZooKeeper.States.CONNECTED);
    --- End diff --
    
    Right, there is no need for this check (which use polling which is not recommended.).
createClient already ensures that zk is in connected state via watchers. The only benefit
of additional check here might be that in case of flaky test environment, a zk might loss
connection to server right after createClient, but in that case we might want to wrap the
subsequent test code (i.e. create) using retry with timeout logic.


> Upgrading to a global session fails with a multiop
> --------------------------------------------------
>
>                 Key: ZOOKEEPER-2725
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2725
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 3.5.2
>            Reporter: Brian Nixon
>
> On an ensemble with local sessions enabled, when a client with a local session requests
the creation of an ephemeral node within a multi-op, the client gets a session expired message.
 The same multi-op works if the session is already global. This breaks the client's expectation
of seamless promotion from local session to global session server-side. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message