zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2693) DOS attack on wchp/wchc four letter words (4lw)
Date Thu, 02 Mar 2017 19:56:45 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15892881#comment-15892881
] 

ASF GitHub Bot commented on ZOOKEEPER-2693:
-------------------------------------------

Github user arshadmohammad commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/179#discussion_r104015988
  
    --- Diff: src/java/test/org/apache/zookeeper/test/FourLetterWordsWhiteListTest.java ---
    @@ -0,0 +1,163 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.zookeeper.test;
    +
    +import java.io.IOException;
    +
    +import org.apache.zookeeper.TestableZooKeeper;
    +import org.apache.zookeeper.common.X509Exception.SSLContextException;
    +
    +import static org.apache.zookeeper.client.FourLetterWordMain.send4LetterWord;
    +
    +import org.apache.zookeeper.server.command.FourLetterCommands;
    +import org.junit.Assert;
    +import org.junit.Test;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +public class FourLetterWordsWhiteListTest extends ClientBase {
    +    protected static final Logger LOG =
    +        LoggerFactory.getLogger(FourLetterWordsWhiteListTest.class);
    +
    +    /*
    +     * ZOOKEEPER-2693: test white list of four letter words.
    +     * For 3.5.x default white list is empty. Verify that is
    +     * the case (except 'stat' command which is enabled in ClientBase
    +     * which other tests depend on.).
    +     */
    +    @Test(timeout=30000)
    +    public void testFourLetterWordsAllDisabledByDefault() throws Exception {
    +        stopServer();
    +        FourLetterCommands.resetWhiteList();
    +        System.setProperty("zookeeper.4lw.commands.whitelist", "stat");
    +        startServer();
    +
    +        // Default white list for 3.5.x is empty, so all command should fail.
    +        verifyAllCommandsFail();
    +
    +        TestableZooKeeper zk = createClient();
    +        String sid = getHexSessionId(zk.getSessionId());
    --- End diff --
    
    sid is not used


> DOS attack on wchp/wchc four letter words (4lw)
> -----------------------------------------------
>
>                 Key: ZOOKEEPER-2693
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2693
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: security, server
>    Affects Versions: 3.4.0, 3.5.1, 3.5.2
>            Reporter: Patrick Hunt
>            Assignee: Michael Han
>            Priority: Blocker
>             Fix For: 3.4.10, 3.5.3
>
>         Attachments: ZOOKEEPER-2693-01.patch
>
>
> The wchp/wchc four letter words can be exploited in a DOS attack on the ZK client port
- typically 2181. The following POC attack was recently published on the web:
> https://webcache.googleusercontent.com/search?q=cache:_CNGIz10PRYJ:https://www.exploit-db.com/exploits/41277/+&cd=14&hl=en&ct=clnk&gl=us
> The most straightforward way to block this attack is to not allow access to the client
port to non-trusted clients - i.e. firewall the ZooKeeper service and only allow access to
trusted applications using it for coordination.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message