zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Powell Molleti (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2184) Zookeeper Client should re-resolve hosts when connection attempts fail
Date Thu, 16 Mar 2017 05:50:41 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15927537#comment-15927537
] 

Powell Molleti commented on ZOOKEEPER-2184:
-------------------------------------------

Hi All,

I have worked on some other issue where I had to change StaticHostProvider to contain ServerCfg
class which include the host string provided at config time, the resolved Inetaddress and
SSL cert fingerprint. And also fixing all the plumbing everywhere to carry or operate upon
ServerCfg. Will this be sufficient to address this issue?.
https://github.com/apache/zookeeper/pull/185/files#diff-1b64f5144158570491cfdec2b93b5c79

I have modified this PR to fit needs of having a chance at getting SSL support committed hence
I removed these changes and published a different PR:  https://github.com/apache/zookeeper/pull/188
(has the StaticHostProvider host changes removed and all the plumbing restored) for your reference
to changes with and without StaticHostProvider modified.

Let me know if this a direction worth while pursuing I can carve out just the StaticHostProvider
changes (without the SSL cert fingerprint in ServerCfg) and publish them as a PR.

thanks
Powell.


> Zookeeper Client should re-resolve hosts when connection attempts fail
> ----------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2184
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2184
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: java client
>    Affects Versions: 3.4.6, 3.5.0
>         Environment: Ubuntu 14.04 host, Docker containers for Zookeeper & Kafka
>            Reporter: Robert P. Thille
>            Assignee: Flavio Junqueira
>              Labels: easyfix, patch
>             Fix For: 3.5.4, 3.6.0, 3.4.11
>
>         Attachments: ZOOKEEPER-2184.patch
>
>
> Testing in a Docker environment with a single Kafka instance using a single Zookeeper
instance. Restarting the Zookeeper container will cause it to receive a new IP address. Kafka
will never be able to reconnect to Zookeeper and will hang indefinitely. Updating DNS or /etc/hosts
with the new IP address will not help the client to reconnect as the zookeeper/client/StaticHostProvider
resolves the connection string hosts at creation time and never re-resolves.
> A solution would be for the client to notice that connection attempts fail and attempt
to re-resolve the hostnames in the connectString.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message