zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-236) SSL Support for Atomic Broadcast protocol
Date Fri, 31 Mar 2017 22:54:41 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15951754#comment-15951754
] 

ASF GitHub Bot commented on ZOOKEEPER-236:
------------------------------------------

Github user afine commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/184#discussion_r109263833
  
    --- Diff: src/java/main/org/apache/zookeeper/common/X509Util.java ---
    @@ -214,45 +237,56 @@ public static X509TrustManager createTrustManager(String trustStoreLocation,
Str
                 tmf.init(new CertPathTrustManagerParameters(pbParams));
     
                 for (final TrustManager tm : tmf.getTrustManagers()) {
    -                if (tm instanceof X509TrustManager) {
    +                if (tm instanceof X509ExtendedTrustManager) {
                         return new X509ExtendedTrustManager() {
    -                        HostnameChecker hostnameChecker = HostnameChecker.getInstance(HostnameChecker.TYPE_TLS);
    +                        X509ExtendedTrustManager x509ExtendedTrustManager = (X509ExtendedTrustManager)
tm;
    --- End diff --
    
    Not sure yet. The createTrustManager method might give us all the exposure to this implementation
that we need. I think this will become more obvious as we begin expanding the tests.


> SSL Support for Atomic Broadcast protocol
> -----------------------------------------
>
>                 Key: ZOOKEEPER-236
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-236
>             Project: ZooKeeper
>          Issue Type: New Feature
>          Components: quorum, server
>            Reporter: Benjamin Reed
>            Assignee: Abraham Fine
>            Priority: Minor
>
> We should have the ability to use SSL to authenticate and encrypt the traffic between
ZooKeeper servers. For the most part this is a very easy change. We would probably only want
to support this for TCP based leader elections.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message