zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From geek101 <...@git.apache.org>
Subject [GitHub] zookeeper pull request #184: ZOOKEEPER-236: SSL Support for Atomic Broadcast...
Date Thu, 30 Mar 2017 03:43:28 GMT
Github user geek101 commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/184#discussion_r108835547
  
    --- Diff: src/java/main/org/apache/zookeeper/common/X509Util.java ---
    @@ -214,45 +237,56 @@ public static X509TrustManager createTrustManager(String trustStoreLocation,
Str
                 tmf.init(new CertPathTrustManagerParameters(pbParams));
     
                 for (final TrustManager tm : tmf.getTrustManagers()) {
    -                if (tm instanceof X509TrustManager) {
    +                if (tm instanceof X509ExtendedTrustManager) {
                         return new X509ExtendedTrustManager() {
    -                        HostnameChecker hostnameChecker = HostnameChecker.getInstance(HostnameChecker.TYPE_TLS);
    +                        X509ExtendedTrustManager x509ExtendedTrustManager = (X509ExtendedTrustManager)
tm;
    --- End diff --
    
    Do you think extending X509ExtendedTrustManager outside will help us test it better?.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message