zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From eribeiro <...@git.apache.org>
Subject [GitHub] zookeeper pull request #208: ZOOKEEPER-2280: NettyServerCnxnFactory doesn't ...
Date Mon, 27 Mar 2017 19:17:16 GMT
Github user eribeiro commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/208#discussion_r108255892
  
    --- Diff: src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java ---
    @@ -109,6 +110,20 @@ public void channelConnected(ChannelHandlerContext ctx,
                         zkServer, NettyServerCnxnFactory.this);
                 ctx.setAttachment(cnxn);
     
    +            InetAddress addr = ((InetSocketAddress)cnxn.channel.getRemoteAddress()).getAddress();
    +            Set<NettyServerCnxn> s = ipMap.get(addr);
    --- End diff --
    
    Good catch! Congrats! :smiley:
    
    Now, I am a bit unsure if this:
    
    * this is a real issue and/or worth fixing;
    * how to achieve a good compromise without entangling the logic too much.
    
    Wdyt?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message