zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From eribeiro <...@git.apache.org>
Subject [GitHub] zookeeper pull request #208: ZOOKEEPER-2280: NettyServerCnxnFactory doesn't ...
Date Mon, 27 Mar 2017 18:22:43 GMT
Github user eribeiro commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/208#discussion_r108242965
  
    --- Diff: src/java/test/org/apache/zookeeper/server/NettyServerCnxnTest.java ---
    @@ -84,4 +98,78 @@ public void testSendCloseSession() throws Exception {
                 zk.close();
             }
         }
    +
    +    @Test(timeout = 30000)
    +    public void testMaxClientConnectionsReached() throws Exception {
    +        final int maxClientCnxns = 4;
    +        final int numClients = 10;
    +        createAndTestConnections(numClients, maxClientCnxns, maxClientCnxns);
    +    }
    +
    +    @Test(timeout = 30000)
    +    public void testMaxClientConnectionsDisabled() throws Exception {
    +        final int maxClientCnxns = 0; // disabled cnxns limit
    +        final int numClients = 10;
    +        createAndTestConnections(numClients, maxClientCnxns, numClients);
    +    }
    +
    +    private void createAndTestConnections(int numClients, int maxClientCnxns, int cnxnsAccepted)
throws Exception {
    +
    +        File tmpDir = ClientBase.createTmpDir();
    +        final int CLIENT_PORT = PortAssignment.unique();
    +
    +        ZooKeeperServer zks = new ZooKeeperServer(tmpDir, tmpDir, 3000);
    +        ServerCnxnFactory scf = ServerCnxnFactory.createFactory(CLIENT_PORT, maxClientCnxns);
    +        scf.startup(zks);
    +
    +        try {
    +            assertTrue("waiting for server being up",
    +                    ClientBase.waitForServerUp("127.0.0.1:" + CLIENT_PORT, CONNECTION_TIMEOUT));
    +            assertTrue("Didn't instantiate ServerCnxnFactory with NettyServerCnxnFactory!",
    +                    scf instanceof NettyServerCnxnFactory);
    +
    +            assertEquals(0, scf.getNumAliveConnections());
    +
    +            assertTrue(cnxnsAccepted <= numClients);
    +
    +            final CountDownLatch countDownLatch = new CountDownLatch(cnxnsAccepted);
    +
    +            TestableZooKeeper[] clients = new TestableZooKeeper[numClients];
    +            for (int i = 0; i < numClients; i++) {
    +                clients[i] = new TestableZooKeeper("127.0.0.1:" + CLIENT_PORT, 3000,
new Watcher() {
    +                    @Override
    +                    public void process(WatchedEvent event)
    +                    {
    +                        if (event.getState() == Event.KeeperState.SyncConnected) {
    +                           countDownLatch.countDown();
    +                        }
    +                    }
    +                });
    +            }
    +
    +            countDownLatch.await();
    +
    +            assertEquals(cnxnsAccepted, scf.getNumAliveConnections());
    +
    +            ConcurrentMap<InetAddress, Set<NettyServerCnxn>> ipMap = ((NettyServerCnxnFactory)
scf).ipMap;
    +            assertEquals(1, ipMap.size());
    +            Set<NettyServerCnxn> set = ipMap.get(ipMap.keySet().toArray()[0]);
    +            assertEquals(cnxnsAccepted, set.size());
    +
    +            int connected = 0;
    +            for (int i = 0; i < numClients; i++) {
    +                if (clients[i].getState().isConnected()) connected++;
    --- End diff --
    
    Oops, indeed! +1.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message