zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From eribeiro <...@git.apache.org>
Subject [GitHub] zookeeper pull request #208: ZOOKEEPER-2280: NettyServerCnxnFactory doesn't ...
Date Sat, 25 Mar 2017 04:29:58 GMT
Github user eribeiro commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/208#discussion_r108027802
  
    --- Diff: src/java/main/org/apache/zookeeper/server/NettyServerCnxn.java ---
    @@ -100,11 +101,15 @@ public void close() {
                             + Long.toHexString(sessionId));
                 }
     
    -            synchronized (factory.ipMap) {
    -                Set<NettyServerCnxn> s =
    -                    factory.ipMap.get(((InetSocketAddress)channel
    -                            .getRemoteAddress()).getAddress());
    -                s.remove(this);
    +            InetAddress address = ((InetSocketAddress) channel.getRemoteAddress()).getAddress();
    +            Set<NettyServerCnxn> s = factory.ipMap.get(address);
    --- End diff --
    
    TODO: "This management of the ipMap looks like something that should be done by the factory,
not the connection. should we move this logic to the factory?"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message