zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From eribeiro <...@git.apache.org>
Subject [GitHub] zookeeper pull request #205: ZOOKEEPER-2736 Add a connection rate limiter
Date Fri, 24 Mar 2017 02:43:19 GMT
Github user eribeiro commented on a diff in the pull request:

    --- Diff: src/java/main/org/apache/zookeeper/common/TokenBucket.java ---
    @@ -0,0 +1,88 @@
    +* Licensed to the Apache Software Foundation (ASF) under one
    +* or more contributor license agreements.  See the NOTICE file
    +* distributed with this work for additional information
    +* regarding copyright ownership.  The ASF licenses this file
    +* to you under the Apache License, Version 2.0 (the
    +* "License"); you may not use this file except in compliance
    +* with the License.  You may obtain a copy of the License at
    +*     http://www.apache.org/licenses/LICENSE-2.0
    +* Unless required by applicable law or agreed to in writing, software
    +* distributed under the License is distributed on an "AS IS" BASIS,
    +* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +* See the License for the specific language governing permissions and
    +* limitations under the License.
    +package org.apache.zookeeper.common;
    +import java.util.concurrent.TimeUnit;
    +import java.util.concurrent.atomic.AtomicLong;
    + * Simple rate limiter based on a token bucket.
    +  */
    +public class TokenBucket implements RateLimiter {
    +    // VisibleForTesting
    +    long refreshPeriodNanos = TimeUnit.SECONDS.toNanos(1L);
    +    // VisibleForTesting
    +    volatile long nextRefillTime;
    +    private AtomicLong tokens;
    +    private long capacity;
    +    private long tokensPerPeriod;
    +    public TokenBucket() { }
    +    // VisibleForTesting
    --- End diff --
    Imo, it needs more api documentation, maybe a reference to a paper/book/wiki that explains
the rationale behind this algorith.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message