zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From eribeiro <...@git.apache.org>
Subject [GitHub] zookeeper pull request #205: ZOOKEEPER-2736 Add a connection rate limiter
Date Fri, 24 Mar 2017 02:43:19 GMT
Github user eribeiro commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/205#discussion_r107822984
  
    --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java ---
    @@ -750,4 +761,46 @@ public static void setReconfigEnabled(boolean enabled) {
             reconfigEnabled = enabled;
         }
     
    +    /**
    +     * @return the {@code RateLimiter} to use
    +     */
    +    public static String getRateLimiterImpl() {
    --- End diff --
    
    I am not so sure that creating a couple of static fields is the best approach here...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message