zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rakeshadr <...@git.apache.org>
Subject [GitHub] zookeeper pull request #200: ZOOKEEPER-2712: MiniKdc test case intermittentl...
Date Sun, 19 Mar 2017 03:43:16 GMT
Github user rakeshadr commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/200#discussion_r106797363
  
    --- Diff: src/java/test/org/apache/zookeeper/server/quorum/auth/QuorumAuthUpgradeTest.java
---
    @@ -83,7 +83,7 @@ public void testNullAuthLearnerServer() throws Exception {
             Map<String, String> authConfigs = new HashMap<String, String>();
             authConfigs.put(QuorumAuth.QUORUM_SASL_AUTH_ENABLED, "false");
     
    -        String connectStr = startQuorum(2, authConfigs, 0);
    +        String connectStr = startQuorum(2, authConfigs, 0, false);
    --- End diff --
    
    Only those test cases which are extending `KerberosSecurityTestcase` class has the dependency
with ApacheDS libraries. So, it is not required to add delay for other test cases.
    
     Internally, KerberosSecurityTestcase class is instantiating MiniKdc instance and ZK quorum
auth module does handshaking using the credentials configured in `jaas.config` file.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message