zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From afine <...@git.apache.org>
Subject [GitHub] zookeeper pull request #182: ZOOKEEPER-2709 Clarify documentation around the...
Date Tue, 07 Mar 2017 20:29:32 GMT
Github user afine commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/182#discussion_r104765953
  
    --- Diff: src/docs/src/documentation/content/xdocs/zookeeperProgrammers.xml ---
    @@ -841,9 +841,9 @@
         itself, ZooKeeper associates all the ids that correspond to a
         client with the clients connection. These ids are checked against
         the ACLs of znodes when a clients tries to access a node. ACLs are
    -    made up of pairs of <emphasis>(scheme:expression,
    +    made up of pairs of <emphasis>(scheme:id,
    --- End diff --
    
    I'm not sure if this is the best way to clarify here. As demonstrated below with the ip
address example, the second field can be an "expression" that matches against ids. Although
in the code we occasionally refer to the second term as an "id" (`ap.matches(authId.getId(),
id.getId())` in `PrepRequestProcessor`) we do also refer to it as an "expression" in other
places (`boolean matches(String id, String aclExpr)` in `AuthenticationProvider`).
    
    I think continuing to refer to the second term as an "expression" and explaining exactly
what an "expression" is may be clearer.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message