Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@zookeeper.apache.org
Date: Mon, 20 Feb 2017 13:13:44 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: dev@zookeeper.apache.org
Message-ID: <JIRA.13044001.1487339716000.10429.1487596424349@Atlassian.JIRA>
In-Reply-To: <JIRA.13044001.1487339716000@Atlassian.JIRA>
References: <JIRA.13044001.1487339716000@Atlassian.JIRA> <JIRA.13044001.1487339716971@jira-lw-us.apache.org>
Subject: [jira] [Commented] (ZOOKEEPER-2700) Force ZooKeeper to generate
 snapshot
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 20 Feb 2017 13:13:49 -0000


    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15874512#comment-15874512 ] 

ASF GitHub Bot commented on ZOOKEEPER-2700:
-------------------------------------------

Github user eribeiro commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/180#discussion_r101970085
  
    --- Diff: src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java ---
    @@ -303,15 +305,38 @@ public void loadData() throws IOException, InterruptedException {
     
         public void takeSnapshot(){
             try {
    +            lastSnapshotZxid = zkDb.getDataTreeLastProcessedZxid();
    +            isGeneratingSnapshot.incrementAndGet();
    +
                 txnLogFactory.save(zkDb.getDataTree(), zkDb.getSessionWithTimeOuts());
             } catch (IOException e) {
                 LOG.error("Severe unrecoverable error, exiting", e);
                 // This is a severe error that we cannot recover from,
                 // so we need to exit
                 System.exit(10);
    +        } finally {
    +            isGeneratingSnapshot.decrementAndGet();
             }
         }
     
    +    public boolean tryTakeSnapshot() {
    --- End diff --
    
    In Java codebases we usually replace the "try" prefix by "maybe". ;)
    
    So it becomes `maybeTakeSnapshot()`.


> Force ZooKeeper to generate snapshot
> ------------------------------------
>
>                 Key: ZOOKEEPER-2700
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2700
>             Project: ZooKeeper
>          Issue Type: Improvement
>            Reporter: Flier Lu
>            Priority: Minor
>
> When cold backup or remote offline sync Zookeeper instances, we need the latest snapshot.
> Add a four letter `snap` command to force Zookeeper to generate snapshot.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)