Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@zookeeper.apache.org
Date: Wed, 8 Feb 2017 20:07:41 +0000 (UTC)
From: "Ryan Zhang (JIRA)" <jira@apache.org>
To: dev@zookeeper.apache.org
Message-ID: <JIRA.13040862.1486444982000.31774.1486584461668@Atlassian.JIRA>
In-Reply-To: <JIRA.13040862.1486444982000@Atlassian.JIRA>
References: <JIRA.13040862.1486444982000@Atlassian.JIRA> <JIRA.13040862.1486444982984@jira-lw-us.apache.org>
Subject: [jira] [Comment Edited] (ZOOKEEPER-2684) Fix a crashing bug in the
 mixed workloads commit processor
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Wed, 08 Feb 2017 20:07:55 -0000


    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2684?page=3Dcom.atlas=
sian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D=
15858474#comment-15858474 ]=20

Ryan Zhang edited comment on ZOOKEEPER-2684 at 2/8/17 8:07 PM:
---------------------------------------------------------------

Hi, Kfir, when I mean a quorum based test I mean a test class that extends =
QuorumBase.

as for your patch, the biggest question for me is that how does it check th=
at the commit is not duplicated? The request could have been processed in t=
he queue before. On a high level, I am not sure what piece of code ensures =
that won't happen (I assume in the lead code but I don't know on top of my =
head). My approach is to remember the first CXid ever appeared but it's kin=
da messy. If you can point me to that code guarantee no duplication and no =
reorder then I think I would be happy to not be so strict here in the commi=
tProcessor


was (Author: nerdyyatrice):
Hi, Kfir, when I mean a quorum based test I mean a test class that extends =
QuorumBase.

as for your patch, the biggest question for me is that how does it check th=
at the commit is not duplicated? The request could have been processed in t=
he queue before. On a high level, I am not sure what piece of code ensures =
that won't happen (I assume in the lead code but I don't know on top of my =
head). My approach is to remember the first CXid ever appeared but it's kin=
da messy. If you can point me to that code then I think I would be happy to=
 not be so strict here in the commitProcessor


> Fix a crashing bug in the mixed workloads commit processor
> ----------------------------------------------------------
>
>                 Key: ZOOKEEPER-2684
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2684
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 3.6.0
>         Environment: with pretty heavy load on a real cluster
>            Reporter: Ryan Zhang
>            Assignee: Ryan Zhang
>            Priority: Blocker
>         Attachments: ZOOKEEPER-2684.patch
>
>
> We deployed our build with ZOOKEEPER-2024 and it quickly started to crash=
 with the following error
> atla-buh-05-sr1.prod.twttr.net: 2017-01-18 22:24:42,305 - ERROR [CommitPr=
ocessor:2] -org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitPr=
ocessor.java:268) =E2=80=93 Got cxid 0x119fa expected 0x11fc5 for client se=
ssion id 1009079ba470055
> atla-buh-05-sr1.prod.twttr.net: 2017-01-18 22:32:04,746 - ERROR [CommitPr=
ocessor:2] -org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitPr=
ocessor.java:268) =E2=80=93 Got cxid 0x698 expected 0x928 for client sessio=
n id 4002eeb3fd0009d
> atla-buh-05-sr1.prod.twttr.net: 2017-01-18 22:34:46,648 - ERROR [CommitPr=
ocessor:2] -org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitPr=
ocessor.java:268) =E2=80=93 Got cxid 0x8904 expected 0x8f34 for client sess=
ion id 51b8905c90251
> atla-buh-05-sr1.prod.twttr.net: 2017-01-18 22:43:46,834 - ERROR [CommitPr=
ocessor:2] -org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitPr=
ocessor.java:268) =E2=80=93 Got cxid 0x3a8d expected 0x3ebc for client sess=
ion id 2051af11af900cc
> clearly something is not right in the new commit processor per session qu=
eue implementation.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)