Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@zookeeper.apache.org
Date: Tue, 7 Feb 2017 19:26:42 +0000 (UTC)
From: "Kfir Lev-Ari (JIRA)" <jira@apache.org>
To: dev@zookeeper.apache.org
Message-ID: <JIRA.13040862.1486444982000.20134.1486495602808@Atlassian.JIRA>
In-Reply-To: <JIRA.13040862.1486444982000@Atlassian.JIRA>
References: <JIRA.13040862.1486444982000@Atlassian.JIRA> <JIRA.13040862.1486444982984@jira-lw-us.apache.org>
Subject: [jira] [Commented] (ZOOKEEPER-2684) Fix a crashing bug in the mixed
 workloads commit processor
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Tue, 07 Feb 2017 19:26:49 -0000


    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2684?page=3Dcom.atlas=
sian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D=
15856615#comment-15856615 ]=20

Kfir Lev-Ari commented on ZOOKEEPER-2684:
-----------------------------------------

Hi Ryan, is it possible that the reason you see this type of bad behavior i=
s because it wasn't examined before in the commit processor? i.e., it's a n=
ew error message that we added in order to notify that commit messages don'=
t follow their client order.=20
I wonder, can you to add to an un-patched version the same error message? (=
and see if you get that error)=20
e.g., before [this|https://github.com/apache/zookeeper/commit/9fc632c4f0a34=
0b0a00ec6dff39c7b454c802822?diff=3Dsplit#diff-5cc688a027068714af01b0ad4d292=
fe5L223] point, add something like       =20

if (pending !=3D null && pending.sessionId =3D=3D request.sessionId && pend=
ing.cxid > request.cxid)=20
 LOG.error("Got cxid 0x " + Long.toHexString(request.cxid) + " expected 0x"=
 + Long.toHexString(pending.cxid) + " for client session id " + Long.toHexS=
tring(request.sessionId));
 throw new IOException("Error: unexpected cxid for" + "client session");


> Fix a crashing bug in the mixed workloads commit processor
> ----------------------------------------------------------
>
>                 Key: ZOOKEEPER-2684
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2684
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 3.6.0
>         Environment: with pretty heavy load on a real cluster
>            Reporter: Ryan Zhang
>            Assignee: Ryan Zhang
>            Priority: Blocker
>
> We deployed our build with ZOOKEEPER-2024 and it quickly started to crash=
 with the following error
> atla-buh-05-sr1.prod.twttr.net: 2017-01-18 22:24:42,305 - ERROR [CommitPr=
ocessor:2] -org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitPr=
ocessor.java:268) =E2=80=93 Got cxid 0x119fa expected 0x11fc5 for client se=
ssion id 1009079ba470055
> atla-buh-05-sr1.prod.twttr.net: 2017-01-18 22:32:04,746 - ERROR [CommitPr=
ocessor:2] -org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitPr=
ocessor.java:268) =E2=80=93 Got cxid 0x698 expected 0x928 for client sessio=
n id 4002eeb3fd0009d
> atla-buh-05-sr1.prod.twttr.net: 2017-01-18 22:34:46,648 - ERROR [CommitPr=
ocessor:2] -org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitPr=
ocessor.java:268) =E2=80=93 Got cxid 0x8904 expected 0x8f34 for client sess=
ion id 51b8905c90251
> atla-buh-05-sr1.prod.twttr.net: 2017-01-18 22:43:46,834 - ERROR [CommitPr=
ocessor:2] -org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitPr=
ocessor.java:268) =E2=80=93 Got cxid 0x3a8d expected 0x3ebc for client sess=
ion id 2051af11af900cc
> clearly something is not right in the new commit processor per session qu=
eue implementation.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)