Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@zookeeper.apache.org
From: flier <git@git.apache.org>
To: dev@zookeeper.apache.org
Reply-To: dev@zookeeper.apache.org
References: <git-pr-180-zookeeper@git.apache.org>
In-Reply-To: <git-pr-180-zookeeper@git.apache.org>
Subject: [GitHub] zookeeper pull request #180: ZOOKEEPER-2700 add JMX `takeSnapshot` method an...
Content-Type: text/plain
Message-Id: <20170222024548.1804CDFEF5@git1-us-west.apache.org>
Date: Wed, 22 Feb 2017 02:45:48 +0000 (UTC)
archived-at: Wed, 22 Feb 2017 02:45:50 -0000

Github user flier commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/180#discussion_r102372975
  
    --- Diff: src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java ---
    @@ -303,15 +305,38 @@ public void loadData() throws IOException, InterruptedException {
     
         public void takeSnapshot(){
    --- End diff --
    
    @hanm Thanks for your advice :)
    
    We are using a similar structure as `2.2 Alternative 2 – Learners` in the paper, it is good enough for most of online scenes. I don't think it is worthy to introduce another layer because we give up the write operation to all observers, just use it as a read only view.
    
    For the remote replication, I doubt it also blocked by packet loss rate like Observer. On the other hand, we have an internal project named `zkpipe`, it read Zookeeper snapshot/binlog and send it to a Kafka topic, our client could choose to rebuild the transaction or subscribe the changes. I believe it will better than hack Zookeeper itself. If you have interested, I could push it to github later.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---