Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@zookeeper.apache.org
From: eribeiro <git@git.apache.org>
To: dev@zookeeper.apache.org
Reply-To: dev@zookeeper.apache.org
References: <git-pr-173-zookeeper@git.apache.org>
In-Reply-To: <git-pr-173-zookeeper@git.apache.org>
Subject: [GitHub] zookeeper pull request #173: ZOOKEEPER-2691: recreateSocketAddresses may rec...
Content-Type: text/plain
Message-Id: <20170217210502.D3E38DFF40@git1-us-west.apache.org>
Date: Fri, 17 Feb 2017 21:05:02 +0000 (UTC)
archived-at: Fri, 17 Feb 2017 21:05:05 -0000

Github user eribeiro commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/173#discussion_r101843855
  
    --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java ---
    @@ -113,13 +113,21 @@ private QuorumServer(long id, InetSocketAddress addr,
                 this.id = id;
                 this.addr = addr;
                 this.electionAddr = electionAddr;
    +            String checkIPReachableValue = System.getProperty("zookeeper.checkIPTimeout");
    +            if(checkIPReachableValue != null){
    +                this.checkIPReachableTO = Integer.parseInt(checkIPReachableValue);
    +            }    
             }
     
             // VisibleForTesting
             public QuorumServer(long id, InetSocketAddress addr) {
                 this.id = id;
                 this.addr = addr;
                 this.electionAddr = null;
    +            String checkIPReachableValue = System.getProperty("zookeeper.checkIPTimeout");
    +            if(checkIPReachableValue != null){
    --- End diff --
    
    nit: space between if and (


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---