Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@zookeeper.apache.org
From: arshadmohammad <git@git.apache.org>
To: dev@zookeeper.apache.org
Reply-To: dev@zookeeper.apache.org
References: <git-pr-179-zookeeper@git.apache.org>
In-Reply-To: <git-pr-179-zookeeper@git.apache.org>
Subject: [GitHub] zookeeper pull request #179: ZOOKEEPER-2693: DOS attack on wchp/wchc four le...
Content-Type: text/plain
Message-Id: <20170217183326.62FB3DFBD3@git1-us-west.apache.org>
Date: Fri, 17 Feb 2017 18:33:26 +0000 (UTC)
archived-at: Fri, 17 Feb 2017 18:33:28 -0000

Github user arshadmohammad commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/179#discussion_r101818292
  
    --- Diff: src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java ---
    @@ -479,7 +479,7 @@ private boolean checkFourLetterWord(final SelectionKey k, final int len)
             // We take advantage of the limited size of the length to look
             // for cmds. They are all 4-bytes which fits inside of an int
             String cmd = FourLetterCommands.getCmdMapView().get(len);
    -        if (cmd == null) {
    +        if (cmd == null || !FourLetterCommands.getWhiteListedCmdView().contains(cmd)) {
    --- End diff --
    
    if request is for 4lw command, it should be processed in that way only. If false is returned from here, the request will proceed as the normal request.
    This is major issue in the current patch


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---