Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@zookeeper.apache.org
From: nerdyyatrice <git@git.apache.org>
To: dev@zookeeper.apache.org
Reply-To: dev@zookeeper.apache.org
References: <git-pr-167-zookeeper@git.apache.org>
In-Reply-To: <git-pr-167-zookeeper@git.apache.org>
Subject: [GitHub] zookeeper pull request #167: commitProcessor does not crash when an unseen c...
Content-Type: text/plain
Message-Id: <20170213065209.44394DFC31@git1-us-west.apache.org>
Date: Mon, 13 Feb 2017 06:52:09 +0000 (UTC)
archived-at: Mon, 13 Feb 2017 06:52:16 -0000

Github user nerdyyatrice commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/167#discussion_r100733084
  
    --- Diff: src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorConcurrencyTest.java ---
    @@ -106,6 +106,7 @@ public void shutdown() {
     
                     @Override
                     public void notifyStopping(String threadName, int errorCode) {
    +                    Assert.fail("Commit processor crashed " + errorCode);
    --- End diff --
    
    My first commit failed as I used lamba so I changed it back to Java 7 style. I forgot to change the commit message when I submit the second one. I will see how to amend that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---