zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From afine <...@git.apache.org>
Subject [GitHub] zookeeper pull request #171: ZOOKEEPER-2692: Fix race condition in testWatch...
Date Fri, 10 Feb 2017 18:13:47 GMT
GitHub user afine opened a pull request:

    https://github.com/apache/zookeeper/pull/171

    ZOOKEEPER-2692: Fix race condition in testWatchAutoResetWithPending

    We occasionally run into an issue with testWatchAutoResetWithPending where we get flaky
test behavior due to not being able to reliably predict when the client has received notification
from each watch that may be fired (perhaps due to resource contention on the box running the
tests). This patch works around that by waiting for a one second quiet period, after which
we can more safely assume all watches that will be fired have been fired.
    
    Here is an example of the test failure: https://builds.apache.org/job/ZooKeeper-trunk-jdk8/935/testReport/junit/org.apache.zookeeper.test/WatcherTest/testWatchAutoResetWithPending/

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/afine/zookeeper ZOOKEEPER-2692

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zookeeper/pull/171.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #171
    
----
commit f2d02bbef77f85e5786345d1ec75240add0d1504
Author: Abraham Fine <abefine@cloudera.com>
Date:   2017-02-10T17:55:10Z

    ZOOKEEPER-2692: Fix race condition in testWatchAutoResetWithPending

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message