zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2700) Force ZooKeeper to generate snapshot
Date Tue, 21 Feb 2017 15:46:44 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15876175#comment-15876175
] 

ASF GitHub Bot commented on ZOOKEEPER-2700:
-------------------------------------------

Github user flier commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/180#discussion_r102238878
  
    --- Diff: src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java ---
    @@ -303,15 +305,38 @@ public void loadData() throws IOException, InterruptedException
{
     
         public void takeSnapshot(){
    --- End diff --
    
    If we are not expect to take snapshot on same time, the most easy way is to use `AtomicBoolean
` protect the `takeSnapshot` from all the code path, which may block the `SyncRequestProcessor`
a while if a manual task is ongoing. My current code is assuming the background `SyncRequestProcessor`
have higher priority.
    



> Force ZooKeeper to generate snapshot
> ------------------------------------
>
>                 Key: ZOOKEEPER-2700
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2700
>             Project: ZooKeeper
>          Issue Type: Improvement
>            Reporter: Flier Lu
>            Priority: Minor
>
> When cold backup or remote offline sync Zookeeper instances, we need the latest snapshot.
> Add a four letter `snap` command to force Zookeeper to generate snapshot.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message