zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2672) Remove CHANGE.txt
Date Fri, 10 Feb 2017 02:35:42 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15860574#comment-15860574
] 

ASF GitHub Bot commented on ZOOKEEPER-2672:
-------------------------------------------

GitHub user hanm opened a pull request:

    https://github.com/apache/zookeeper/pull/168

    ZOOKEEPER-2672: Remove CHANGE.txt.

    The CHANGE.txt is already not the source of truth of what's changed after we migrating
to git - most of the git commits in recent couple of months don't update CHANGE.txt. The option
of updating CHANGE.txt during commit flow automatically is none trivial, and do that manually
is cumbersome and error prone.
    The consensus is we would rely on source control revision logs instead of CHANGE.txt moving
forward; see https://www.mail-archive.com/dev@zookeeper.apache.org/msg37108.html for more
details.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hanm/zookeeper ZOOKEEPER-2672-branch-3.4

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zookeeper/pull/168.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #168
    
----
commit a902a47d5e2a983534e2b7db24e712292e59677b
Author: Michael Han <hanm@apache.org>
Date:   2017-02-10T02:32:26Z

    ZOOKEEPER-2672: Remove CHANGE.txt.
    The CHANGE.txt is already not the source of truth of what's changed after we migrating
to git - most of the git commits in recent couple of months don't update CHANGE.txt. The option
of updating CHANGE.txt during commit flow automatically is none trivial, and do that manually
is cumbersome and error prone.
    The consensus is we would rely on source control revision logs instead of CHANGE.txt moving
forward; see https://www.mail-archive.com/dev@zookeeper.apache.org/msg37108.html for more
details.

----


> Remove CHANGE.txt
> -----------------
>
>                 Key: ZOOKEEPER-2672
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2672
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 3.4.9, 3.5.2
>            Reporter: Michael Han
>            Assignee: Michael Han
>             Fix For: 3.4.10, 3.5.3, 3.6.0
>
>
> The CHANGE.txt is already not the source of truth of what's changed after we migrating
to git - most of the git commits in recent couple of months don't update CHANGE.txt. The option
of updating CHANGE.txt during commit flow automatically is none trivial, and do that manually
is cumbersome and error prone.
> The consensus is we would rely on source control revision logs instead of CHANGE.txt
moving forward; see https://www.mail-archive.com/dev@zookeeper.apache.org/msg37108.html for
more details.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message