zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2665) Port QA github pull request build to branch 3.4 and 3.5
Date Tue, 14 Feb 2017 19:37:42 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15866469#comment-15866469
] 

ASF GitHub Bot commented on ZOOKEEPER-2665:
-------------------------------------------

Github user eribeiro commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/165#discussion_r100269807
  
    --- Diff: src/java/test/bin/test-github-pr.sh ---
    @@ -0,0 +1,616 @@
    +#!/usr/bin/env bash
    +#   Licensed under the Apache License, Version 2.0 (the "License");
    +#   you may not use this file except in compliance with the License.
    +#   You may obtain a copy of the License at
    +#
    +#       http://www.apache.org/licenses/LICENSE-2.0
    +#
    +#   Unless required by applicable law or agreed to in writing, software
    +#   distributed under the License is distributed on an "AS IS" BASIS,
    +#   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +#   See the License for the specific language governing permissions and
    +#   limitations under the License.
    +
    +
    +#set -x
    +
    +### Setup some variables.
    +### GIT_COMMIT and BUILD_URL are set by Hudson if it is run by patch process
    +### Read variables from properties file
    +. `dirname $0`/test-patch.properties
    +
    +###############################################################################
    +parseArgs() {
    +  case "$1" in
    +    QABUILD)
    +      ### Set QABUILD to true to indicate that this script is being run by Hudson
    +      QABUILD=true
    +      if [[ $# != 14 ]] ; then
    +        echo "ERROR: usage $0 QABUILD <PATCH_DIR> <PS_CMD> <WGET_CMD>
<JIRACLI> <GIT_CMD> <GREP_CMD> <PATCH_CMD> <FINDBUGS_HOME> <FORREST_HOME>
<WORKSPACE_BASEDIR> <JIRA_PASSWD> <JAVA5_HOME> <CURL_CMD>"
    +        cleanupAndExit 0
    +      fi
    +      PATCH_DIR=$2
    +      PS=$3
    +      WGET=$4
    +      JIRACLI=$5
    +      GIT=$6
    +      GREP=$7
    +      PATCH=$8
    +      FINDBUGS_HOME=$9
    +      FORREST_HOME=${10}
    +      BASEDIR=${11}
    +      JIRA_PASSWD=${12}
    +      JAVA5_HOME=${13}
    +      CURL=${14}
    +      if [ ! -e "$PATCH_DIR" ] ; then
    +        mkdir -p $PATCH_DIR
    +      fi
    +
    +      ## Obtain PR number and title
    +      PULLREQUEST_ID=${GIT_PR_NUMBER}
    +      PULLREQUEST_TITLE="${GIT_PR_TITLE}"
    +
    +      ## Extract jira number from PR title
    +      local prefix=${PULLREQUEST_TITLE%ZOOKEEPER\-[0-9]*}
    +      local noprefix=${PULLREQUEST_TITLE#$prefix}
    +      local regex='\(ZOOKEEPER-.[0-9]*\)'
    +      defect=$(expr "$noprefix" : ${regex})
    +
    +      echo "Pull request id: ${PULLREQUEST_ID}"
    +      echo "Pull request title: ${PULLREQUEST_TITLE}"
    +      echo "Defect number: ${defect}"
    +
    +      JIRA_COMMENT="GitHub Pull Request ${PULLREQUEST_NUMBER} Build
    +      "
    +      ;;
    +    DEVELOPER)
    +      ### Set QABUILD to false to indicate that this script is being run by a developer
    +      QABUILD=false
    +      if [[ $# != 10 ]] ; then
    +        echo "ERROR: usage $0 DEVELOPER <GIT_PR_URL> <SCRATCH_DIR> <GIT_CMD>
<GREP_CMD> <PATCH_CMD> <FINDBUGS_HOME> <FORREST_HOME> <WORKSPACE_BASEDIR>
<JAVA5_HOME>"
    +        cleanupAndExit 0
    +      fi
    +      PATCH_DIR=$3
    +      PATCH_FILE=${PATCH_DIR}/patch
    +      curl -L $2.diff > ${PATCH_FILE}
    +      ### PATCH_FILE contains the location of the patchfile
    +      if [[ ! -e "$PATCH_FILE" ]] ; then
    +        echo "Unable to locate the patch file $PATCH_FILE"
    +        cleanupAndExit 0
    +      fi
    +      ### Check if $PATCH_DIR exists. If it does not exist, create a new directory
    +      if [[ ! -e "$PATCH_DIR" ]] ; then
    +	mkdir "$PATCH_DIR"
    +	if [[ $? == 0 ]] ; then
    +	  echo "$PATCH_DIR has been created"
    +	else
    +	  echo "Unable to create $PATCH_DIR"
    +	  cleanupAndExit 0
    +	fi
    +      fi
    +      GIT=$4
    +      GREP=$5
    +      PATCH=$6
    +      FINDBUGS_HOME=$7
    +      FORREST_HOME=$8
    +      BASEDIR=$9
    +      JAVA5_HOME=${10}
    --- End diff --
    
    As above.


> Port QA github pull request build to branch 3.4 and 3.5
> -------------------------------------------------------
>
>                 Key: ZOOKEEPER-2665
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2665
>             Project: ZooKeeper
>          Issue Type: Test
>          Components: build
>            Reporter: Flavio Junqueira
>             Fix For: 3.5.3, 3.4.11
>
>
> We have QA build for pull requests against master but not against branches 3.4 and 3.5.
We need to port the necessary wiring to do it, it shouldn't be difficult.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message