zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2642) ZooKeeper reconfig API backward compatibility fix
Date Sun, 12 Feb 2017 00:35:41 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15862601#comment-15862601

Hudson commented on ZOOKEEPER-2642:

FAILURE: Integrated in Jenkins build ZooKeeper-trunk #3275 (See [https://builds.apache.org/job/ZooKeeper-trunk/3275/])
ZOOKEEPER-2642: rename ZooKeeper reconfig API to reconfigure API. (hanm: rev c5df1c9acec07036da225b1251cb30be60301224)
* (edit) src/java/main/org/apache/zookeeper/cli/ReconfigCommand.java
* (edit) src/java/test/org/apache/zookeeper/server/quorum/ReconfigFailureCasesTest.java
* (edit) src/java/test/org/apache/zookeeper/server/quorum/ReconfigDuringLeaderSyncTest.java
* (edit) src/java/test/org/apache/zookeeper/test/ReconfigExceptionTest.java
* (edit) src/java/test/org/apache/zookeeper/test/ReconfigTest.java
* (edit) src/java/main/org/apache/zookeeper/admin/ZooKeeperAdmin.java
* (edit) src/java/test/org/apache/zookeeper/test/StandaloneTest.java
* (edit) src/java/test/org/apache/zookeeper/server/quorum/StandaloneDisabledTest.java
* (edit) src/java/test/org/apache/zookeeper/test/ReconfigMisconfigTest.java

> ZooKeeper reconfig API backward compatibility fix
> -------------------------------------------------
>                 Key: ZOOKEEPER-2642
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2642
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: c client, java client
>    Affects Versions: 3.5.2
>            Reporter: Jordan Zimmerman
>            Assignee: Jordan Zimmerman
>            Priority: Blocker
>             Fix For: 3.5.3, 3.6.0
>         Attachments: ZOOKEEPER-2642-3.5.patch, ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch,
ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch
> ZOOKEEPER-2014 moved the reconfig() methods into a new class, ZooKeeperAdmin. It appears
this was done to document that these are methods have access restrictions. However, this change
breaks Apache Curator (and possibly other clients). Curator APIs will have to be changed and/or
special methods need to be added. A breaking change of this kind should only be done when
the benefit is overwhelming. In this case, the same information can be conveyed with documentation
and possibly a deprecation notice.
> Revert the creation of the ZooKeeperAdmin class and move the reconfig() methods back
to the ZooKeeper class with additional documentation.

This message was sent by Atlassian JIRA

View raw message