zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hanm <...@git.apache.org>
Subject [GitHub] zookeeper pull request #179: ZOOKEEPER-2693: DOS attack on wchp/wchc four le...
Date Tue, 28 Feb 2017 18:45:27 GMT
Github user hanm commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/179#discussion_r103512572
  
    --- Diff: src/java/main/org/apache/zookeeper/server/command/FourLetterCommands.java ---
    @@ -216,6 +216,10 @@ public static boolean isEnabled(String command) {
                         whiteListedCommands.add(cmd.trim());
                     }
                 }
    +            // It is sad that isro and srvr are used by ZooKeeper itself. Need fix this
    +            // before deprecating 4lw.
    +            whiteListedCommands.add("isro");
    --- End diff --
    
    @rakeshadr thanks for feedback, updated patch. I also did an optimization that only conditionally
enables "isro" only when read only mode is enabled (readonly mode is disabled by default.)
with a test case, so we don't have to say that "isro" is also enabled by default in doc (the
less implementation details we mention there the better imo.).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message