zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From flier <...@git.apache.org>
Subject [GitHub] zookeeper pull request #180: ZOOKEEPER-2700 add JMX `takeSnapshot` method an...
Date Tue, 21 Feb 2017 15:46:01 GMT
Github user flier commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/180#discussion_r102238878
  
    --- Diff: src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java ---
    @@ -303,15 +305,38 @@ public void loadData() throws IOException, InterruptedException
{
     
         public void takeSnapshot(){
    --- End diff --
    
    If we are not expect to take snapshot on same time, the most easy way is to use `AtomicBoolean
` protect the `takeSnapshot` from all the code path, which may block the `SyncRequestProcessor`
a while if a manual task is ongoing. My current code is assuming the background `SyncRequestProcessor`
have higher priority.
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message