zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From flier <...@git.apache.org>
Subject [GitHub] zookeeper pull request #180: ZOOKEEPER-2700 add JMX `takeSnapshot` method an...
Date Mon, 20 Feb 2017 14:28:45 GMT
Github user flier commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/180#discussion_r102028811
  
    --- Diff: src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java ---
    @@ -303,15 +305,38 @@ public void loadData() throws IOException, InterruptedException
{
     
         public void takeSnapshot(){
             try {
    +            lastSnapshotZxid = zkDb.getDataTreeLastProcessedZxid();
    +            isGeneratingSnapshot.incrementAndGet();
    +
                 txnLogFactory.save(zkDb.getDataTree(), zkDb.getSessionWithTimeOuts());
             } catch (IOException e) {
                 LOG.error("Severe unrecoverable error, exiting", e);
                 // This is a severe error that we cannot recover from,
                 // so we need to exit
                 System.exit(10);
    +        } finally {
    +            isGeneratingSnapshot.decrementAndGet();
             }
         }
     
    +    public boolean tryTakeSnapshot() {
    --- End diff --
    
    hmm...I haven't working on Java for years, forgive me :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message