zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From eribeiro <...@git.apache.org>
Subject [GitHub] zookeeper pull request #180: ZOOKEEPER-2700 add JMX `takeSnapshot` method an...
Date Mon, 20 Feb 2017 13:13:00 GMT
Github user eribeiro commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/180#discussion_r101969629
  
    --- Diff: src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java ---
    @@ -126,6 +125,9 @@
         private final ZooKeeperServerListener listener;
         private ZooKeeperServerShutdownHandler zkShutdownHandler;
     
    +    private volatile long lastSnapshotZxid;
    +    private AtomicInteger isGeneratingSnapshot = new AtomicInteger(0);
    --- End diff --
    
    You could use an `AtomicBoolean` here, right?
    
    Make `isGeneratingSnapshot` **final**, please.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message