zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From eribeiro <...@git.apache.org>
Subject [GitHub] zookeeper pull request #173: ZOOKEEPER-2691: recreateSocketAddresses may rec...
Date Fri, 17 Feb 2017 21:05:02 GMT
Github user eribeiro commented on a diff in the pull request:

    --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java ---
    @@ -113,13 +113,21 @@ private QuorumServer(long id, InetSocketAddress addr,
                 this.id = id;
                 this.addr = addr;
                 this.electionAddr = electionAddr;
    +            String checkIPReachableValue = System.getProperty("zookeeper.checkIPTimeout");
    --- End diff --
    I think we can improve this naming game just a little bit. Why not call this variable
`ipTimeout`? And `checkIPReachableTO` as `ipReachableTimeout` or `reachableIPTimeout`? 

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message