zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From eribeiro <...@git.apache.org>
Subject [GitHub] zookeeper pull request #165: ZOOKEEPER-2665 Port QA github pull request buil...
Date Tue, 14 Feb 2017 19:36:58 GMT
Github user eribeiro commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/165#discussion_r100269721
  
    --- Diff: src/java/test/bin/test-github-pr.sh ---
    @@ -0,0 +1,616 @@
    +#!/usr/bin/env bash
    +#   Licensed under the Apache License, Version 2.0 (the "License");
    +#   you may not use this file except in compliance with the License.
    +#   You may obtain a copy of the License at
    +#
    +#       http://www.apache.org/licenses/LICENSE-2.0
    +#
    +#   Unless required by applicable law or agreed to in writing, software
    +#   distributed under the License is distributed on an "AS IS" BASIS,
    +#   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +#   See the License for the specific language governing permissions and
    +#   limitations under the License.
    +
    +
    +#set -x
    +
    +### Setup some variables.
    +### GIT_COMMIT and BUILD_URL are set by Hudson if it is run by patch process
    +### Read variables from properties file
    +. `dirname $0`/test-patch.properties
    +
    +###############################################################################
    +parseArgs() {
    +  case "$1" in
    +    QABUILD)
    +      ### Set QABUILD to true to indicate that this script is being run by Hudson
    +      QABUILD=true
    +      if [[ $# != 14 ]] ; then
    +        echo "ERROR: usage $0 QABUILD <PATCH_DIR> <PS_CMD> <WGET_CMD>
<JIRACLI> <GIT_CMD> <GREP_CMD> <PATCH_CMD> <FINDBUGS_HOME> <FORREST_HOME>
<WORKSPACE_BASEDIR> <JIRA_PASSWD> <JAVA5_HOME> <CURL_CMD>"
    +        cleanupAndExit 0
    +      fi
    +      PATCH_DIR=$2
    +      PS=$3
    +      WGET=$4
    +      JIRACLI=$5
    +      GIT=$6
    +      GREP=$7
    +      PATCH=$8
    +      FINDBUGS_HOME=$9
    +      FORREST_HOME=${10}
    +      BASEDIR=${11}
    +      JIRA_PASSWD=${12}
    +      JAVA5_HOME=${13}
    --- End diff --
    
    Java6 is the mininum JVM required for branch-3.4, no? And Java7 for branch-3.5


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message