zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nerdyyatrice <...@git.apache.org>
Subject [GitHub] zookeeper pull request #167: commitProcessor does not crash when an unseen c...
Date Fri, 10 Feb 2017 19:11:16 GMT
Github user nerdyyatrice commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/167#discussion_r100603293
  
    --- Diff: src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorConcurrencyTest.java
---
    @@ -106,6 +106,7 @@ public void shutdown() {
     
                     @Override
                     public void notifyStopping(String threadName, int errorCode) {
    +                    Assert.fail("Commit processor crashed " + errorCode);
    --- End diff --
    
    I wonder if you have any insight on what does his test do and mine don't? I thought it
was pretty much the same


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message