zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hanm <...@git.apache.org>
Subject [GitHub] zookeeper pull request #159: ZOOKEEPER-2678: Discovery and Sync can take a v...
Date Thu, 09 Feb 2017 19:25:03 GMT
Github user hanm commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/159#discussion_r100389617
  
    --- Diff: src/java/main/org/apache/zookeeper/server/quorum/Learner.java ---
    @@ -498,14 +504,19 @@ else if (qp.getType() == Leader.SNAP) {
                                throw new Exception("changes proposed in reconfig");
                            }
                         }
    -                    if (!snapshotTaken) { // true for the pre v1.0 case
    -                       zk.takeSnapshot();
    +                    if (isPreZAB1_0) {
    +                        zk.takeSnapshot();
                             self.setCurrentEpoch(newEpoch);
                         }
                         self.setZooKeeperServer(zk);
                         self.adminServer.setZooKeeperServer(zk);
                         break outerLoop;
    -                case Leader.NEWLEADER: // it will be NEWLEADER in v1.0        
    +                case Leader.NEWLEADER: // Getting NEWLEADER here instead of in discovery

    +                    // means this is Zab 1.0
    +                    // Create updatingEpoch file and remove it after current
    --- End diff --
    
    This comment does not apply here - my guess is it is a copy paste error from your branch-3.4
patch... can we get this comment removed?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message