zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From afine <...@git.apache.org>
Subject [GitHub] zookeeper pull request #157: ZOOKEEPER-2678: Discovery and Sync can take a v...
Date Thu, 02 Feb 2017 23:04:38 GMT
Github user afine commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/157#discussion_r99242422
  
    --- Diff: src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java ---
    @@ -839,12 +839,25 @@ public void converseWithFollower(InputArchive ia, OutputArchive
oa,
                         Assert.assertEquals(1, f.self.getAcceptedEpoch());
                         Assert.assertEquals(1, f.self.getCurrentEpoch());
                         
    +                    //Wait for the transactions to be written out. The thread that writes
them out
    +                    // does not send anything back when it is done.
    +                    long start = System.currentTimeMillis();
    +                    while (createSessionZxid != f.fzk.getLastProcessedZxid() &&
(System.currentTimeMillis() - start) < 50) {
    --- End diff --
    
    it would be nice, a good way of actually validating everything is behaving as expected


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message